Expand testing coverage for 16-bit deltas in v1 codec#998
Merged
Conversation
We had limited coverage for 16-bit deltas previously: V1Custom test only exercised delta decoding on zero deltas, and VertexDeltas test only had positive deltas which could hide an implementation error with sign bit handling. To fix this, expand decodeVertexDeltas test to have deltas flip the sign in the second half of the data, and add decodeVertexV1Deltas test which has the same data encoded statically.
This test has the same data as the correponding test from demo/tests.cpp and expands testing coverage for 16-bit delta decoding that V1_Custom test was previously lacking.
xPaw
added a commit
to ValveResourceFormat/ValveResourceFormat
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had limited coverage for 16-bit deltas previously: V1Custom test only
exercised delta decoding on zero deltas, and VertexDeltas test only had
positive deltas which could hide an implementation error with sign bit
handling.
To fix this, expand decodeVertexDeltas test to have deltas flip the sign
in the second half of the data, and add decodeVertexV1Deltas test which
has the same data encoded statically.
Thanks to @xPaw for noticing.